IRC chat logs for #ltsp on irc.libera.chat (webchat)
Channel log from 27 September 2013 (all times are UTC)
| 00:00 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 245 seconds) | |
| 00:16 | coffeecoco has joined IRC (coffeecoco!~root@unaffiliated/coffeecoco) | |
| 00:20 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 245 seconds) | |
| 00:41 | away_bennabiy is now known as bennabiy | |
| 00:41 | <bennabiy> Hello all
| |
| 00:43 | <vagrantc> bennabiy: gotta go, but merged the final result into ltsp-trunk
| |
| 00:43 | * vagrantc waves | |
| 00:44 | vagrantc has left IRC (vagrantc!~vagrant@freegeek/vagrantc, Quit: leaving) | |
| 00:49 | coffeecoco has joined IRC (coffeecoco!~root@unaffiliated/coffeecoco) | |
| 00:51 | monkwitdafunk has left IRC (monkwitdafunk!~AndChat49@24.114.27.88, Ping timeout: 256 seconds) | |
| 00:52 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.88) | |
| 00:53 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.88) | |
| 00:53 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.88) | |
| 01:07 | <bennabiy> that is great!
| |
| 01:08 | I wonder how soon until it hits me here.
| |
| 01:14 | Looks like we fixed something and broke another :)
| |
| 01:17 | Is there any way to up the debug level more than just the DEBUG=<script> <script> ?
| |
| 01:36 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 264 seconds) | |
| 01:38 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 01:39 | <bennabiy> Any devs in here?
| |
| 01:41 | work_alkisg: Seems that the if code we used in 000-basic-configuration is failing, so it is defaulting to the else
| |
| 01:42 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Ping timeout: 246 seconds) | |
| 02:53 | coffeecoco has joined IRC (coffeecoco!~root@unaffiliated/coffeecoco) | |
| 03:21 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 03:21 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 03:22 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 03:23 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 03:49 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 264 seconds) | |
| 03:59 | <bennabiy> !bennabiy-todo
| |
| 03:59 | <ltsp`> Error: "bennabiy-todo" is not a valid command.
| |
| 03:59 | <bennabiy> !bennabiy_todo
| |
| 03:59 | <ltsp`> Error: "bennabiy_todo" is not a valid command.
| |
| 04:09 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 04:14 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Ping timeout: 245 seconds) | |
| 04:18 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:19 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:19 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:19 | monkwitdafunk has left IRC (monkwitdafunk!~AndChat49@24.114.27.136, Excess Flood) | |
| 04:20 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:37 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:38 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:38 | alexqwesa has joined IRC (alexqwesa!~alex@109.172.12.47) | |
| 04:38 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:39 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:47 | coffeecoco has joined IRC (coffeecoco!~root@unaffiliated/coffeecoco) | |
| 04:51 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.27.136) | |
| 04:59 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 260 seconds) | |
| 05:08 | coffeecoco has joined IRC (coffeecoco!~root@unaffiliated/coffeecoco) | |
| 05:10 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 05:14 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Ping timeout: 256 seconds) | |
| 05:36 | bobby_C has joined IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at) | |
| 05:44 | bobby_C has left IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at, Quit: Goin' down hard) | |
| 05:48 | mikkel_ has joined IRC (mikkel_!~mikkel@80-199-146-42-static.dk.customer.tdc.net) | |
| 05:51 | freedomrun has joined IRC (freedomrun!~freedomru@unaffiliated/freedomrun) | |
| 05:54 | alexqwesa has left IRC (alexqwesa!~alex@109.172.12.47, Ping timeout: 246 seconds) | |
| 06:10 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 06:15 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Ping timeout: 252 seconds) | |
| 06:29 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 260 seconds) | |
| 06:32 | coffeecoco has joined IRC (coffeecoco!~root@unaffiliated/coffeecoco) | |
| 06:34 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 06:52 | alexqwesa has joined IRC (alexqwesa!~alex@109.172.12.47) | |
| 07:09 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 260 seconds) | |
| 07:14 | coffeecoco has joined IRC (coffeecoco!~root@unaffiliated/coffeecoco) | |
| 07:18 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Ping timeout: 260 seconds) | |
| 07:20 | alkisg has joined IRC (alkisg!c23fefe7@gateway/web/freenode/ip.194.63.239.231) | |
| 07:26 | coffeecoco has left IRC (coffeecoco!~root@unaffiliated/coffeecoco, Ping timeout: 245 seconds) | |
| 07:28 | alkisg has left IRC (alkisg!c23fefe7@gateway/web/freenode/ip.194.63.239.231, Ping timeout: 250 seconds) | |
| 07:44 | alkisg has joined IRC (alkisg!c23fefe7@gateway/web/freenode/ip.194.63.239.231) | |
| 08:03 | bennabiy has left IRC (bennabiy!~Thunderbi@24-181-55-79.dhcp.gnvl.sc.charter.com, Ping timeout: 248 seconds) | |
| 08:04 | bennabiy has joined IRC (bennabiy!~Thunderbi@24-181-55-79.dhcp.gnvl.sc.charter.com) | |
| 08:12 | Gremble has joined IRC (Gremble!~Ben@cpc35-aztw23-2-0-cust207.18-1.cable.virginmedia.com) | |
| 08:12 | Gremble is now known as Guest39153 | |
| 08:14 | khildin has joined IRC (khildin!~khildin@ip-213-49-85-183.dsl.scarlet.be) | |
| 08:18 | monkwitdafunk has left IRC (monkwitdafunk!~AndChat49@24.114.27.136, Ping timeout: 256 seconds) | |
| 08:20 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.39.8) | |
| 08:20 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.39.8) | |
| 08:20 | monkwitdafunk has left IRC (monkwitdafunk!~AndChat49@24.114.39.8, Excess Flood) | |
| 08:21 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.39.8) | |
| 08:21 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.39.8) | |
| 08:38 | khildin has left IRC (khildin!~khildin@ip-213-49-85-183.dsl.scarlet.be, Ping timeout: 264 seconds) | |
| 08:47 | freedomrun has left IRC (freedomrun!~freedomru@unaffiliated/freedomrun, Quit: So long and thanks for all the fish) | |
| 08:52 | khildin has joined IRC (khildin!~khildin@ip-213-49-85-183.dsl.scarlet.be) | |
| 08:52 | work_alkisg has left IRC (work_alkisg!~alkisg@plinet.ioa.sch.gr, Ping timeout: 240 seconds) | |
| 08:53 | work_alkisg has joined IRC (work_alkisg!~alkisg@plinet.ioa.sch.gr) | |
| 08:53 | Guest39153 has left IRC (Guest39153!~Ben@cpc35-aztw23-2-0-cust207.18-1.cable.virginmedia.com, Quit: I Leave) | |
| 08:55 | GrembleBean has joined IRC (GrembleBean!~Ben@cpc35-aztw23-2-0-cust207.18-1.cable.virginmedia.com) | |
| 09:00 | alkisg has left IRC (alkisg!c23fefe7@gateway/web/freenode/ip.194.63.239.231, Quit: Page closed) | |
| 09:01 | biophoton has left IRC (biophoton!~andy@h35.209.22.98.dynamic.ip.windstream.net, Ping timeout: 264 seconds) | |
| 09:18 | alexqwesa has left IRC (alexqwesa!~alex@109.172.12.47, Ping timeout: 248 seconds) | |
| 09:28 | alexqwesa has joined IRC (alexqwesa!~alex@109.172.12.47) | |
| 10:18 | mikkel_ has left IRC (mikkel_!~mikkel@80-199-146-42-static.dk.customer.tdc.net, Quit: Leaving) | |
| 10:20 | engblom has left IRC (engblom!~user@unaffiliated/engblom) | |
| 10:41 | TatankaT has left IRC (TatankaT!~tim@193.190.253.114, Ping timeout: 240 seconds) | |
| 10:42 | biophoton has joined IRC (biophoton!~andy@h35.209.22.98.dynamic.ip.windstream.net) | |
| 10:54 | TatankaT has joined IRC (TatankaT!~tim@193.190.253.114) | |
| 10:58 | GrembleBean has joined IRC (GrembleBean!~Ben@cpc35-aztw23-2-0-cust207.18-1.cable.virginmedia.com) | |
| 10:58 | <bennabiy> Anyone here? vagrantc or alkisg?
| |
| 10:59 | TatankaT has left IRC (TatankaT!~tim@193.190.253.114, Ping timeout: 240 seconds) | |
| 11:06 | TatankaT has joined IRC (TatankaT!~tim@193.190.253.114) | |
| 11:17 | TatankaT has left IRC (TatankaT!~tim@193.190.253.114, Ping timeout: 240 seconds) | |
| 11:23 | biophoton has left IRC (biophoton!~andy@h35.209.22.98.dynamic.ip.windstream.net, Ping timeout: 264 seconds) | |
| 11:25 | TatankaT has joined IRC (TatankaT!~tim@193.190.253.114) | |
| 11:46 | Da-Geek has joined IRC (Da-Geek!~Da-Geek@212.121.110.162) | |
| 11:50 | Phantomas has joined IRC (Phantomas!~Phantomas@ubuntu/member/phantomas) | |
| 12:11 | freedomrun has joined IRC (freedomrun!~freedomru@unaffiliated/freedomrun) | |
| 12:14 | brunolambert has joined IRC (brunolambert!brunolambe@nat/revolutionlinux/x-thpliemsabtodqtp) | |
| 12:24 | alkisg has joined IRC (alkisg!~alkisg@ubuntu/member/alkisg) | |
| 12:29 | awilliam1 has joined IRC (awilliam1!~awilliams@unaffiliated/mistik1) | |
| 12:29 | awilliams has left IRC (awilliams!~awilliams@unaffiliated/mistik1, Ping timeout: 245 seconds) | |
| 12:29 | awilliam1 is now known as awilliams | |
| 12:53 | bobby_C has joined IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at) | |
| 13:03 | alkisg has left IRC (alkisg!~alkisg@ubuntu/member/alkisg, Quit: Leaving.) | |
| 13:29 | Phantomas has left IRC (Phantomas!~Phantomas@ubuntu/member/phantomas, Quit: Leaving.) | |
| 13:37 | bobby_C has left IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at, Ping timeout: 264 seconds) | |
| 14:01 | willianmazzardo has joined IRC (willianmazzardo!~textual@187.53.208.106) | |
| 14:11 | IAFP has joined IRC (IAFP!b186d4db@gateway/web/freenode/ip.177.134.212.219) | |
| 14:20 | ademar_ has joined IRC (ademar_!bb21af56@gateway/web/freenode/ip.187.33.175.86) | |
| 14:29 | IAFP has left IRC (IAFP!b186d4db@gateway/web/freenode/ip.177.134.212.219, Ping timeout: 250 seconds) | |
| 14:39 | bobby_C has joined IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at) | |
| 14:46 | <bennabiy> Anyone here?
| |
| 14:50 | <Hyperbyte> !ask
| |
| 14:50 | <ltsp`> ask: Don't ask to ask a question, simply ask it, and if someone knows the answer, they'll respond. Please hang around for at least a full hour after asking a question, as not everybody constantly monitors the channel.
| |
| 14:54 | <bennabiy> !asked
| |
| 14:54 | <ltsp`> asked: Sometimes the questions asked, which get flagged as !ask, are actually the question...
| |
| 14:55 | <bennabiy> :)
| |
| 14:55 | Hi Hyperbyte
| |
| 14:57 | Hyperbyte, are you one of the devs?
| |
| 15:03 | GrembleBean has left IRC (GrembleBean!~Ben@cpc35-aztw23-2-0-cust207.18-1.cable.virginmedia.com, Quit: I Leave) | |
| 15:06 | PhoenixSTF has joined IRC (PhoenixSTF!~rudi@lidet.uac.pt) | |
| 15:07 | <Hyperbyte> !forget asked
| |
| 15:07 | <ltsp`> Error: There is no such factoid.
| |
| 15:08 | * Hyperbyte frowns | |
| 15:08 | <Hyperbyte> Whatever...
| |
| 15:15 | Phantomas has joined IRC (Phantomas!~Phantomas@ubuntu/member/phantomas) | |
| 15:19 | workingcats has joined IRC (workingcats!~workingca@212.122.48.77) | |
| 15:20 | bobby_C has left IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at, Quit: Goin' down hard) | |
| 15:22 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 15:25 | <bennabiy> heh
| |
| 15:25 | bobby_C has joined IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at) | |
| 15:26 | <bennabiy> !seen alkisg
| |
| 15:26 | <ltsp`> alkisg was last seen in #ltsp 1 day, 0 hours, and 9 seconds ago: <alkisg> Hi willianmazzardo
| |
| 15:27 | <bennabiy> !seen vagrantc
| |
| 15:27 | <ltsp`> vagrantc was last seen in #ltsp 14 hours, 43 minutes, and 19 seconds ago: * vagrantc waves
| |
| 15:46 | ademar_ has left IRC (ademar_!bb21af56@gateway/web/freenode/ip.187.33.175.86, Ping timeout: 250 seconds) | |
| 15:55 | alkisg has joined IRC (alkisg!~alkisg@ubuntu/member/alkisg) | |
| 15:56 | <bennabiy> alkisg, I am bugfixing that line we put in to distinguish between a mint install from a mint server, or a ubuntu install from a mint server. I am about to commit the fix to my repo, and I already requested another merge
| |
| 15:56 | <alkisg> Hi bennabiy
| |
| 15:57 | * alkisg was just looking about that.... | |
| 15:57 | <alkisg> Yeah variables set inside subshells aren't exported to the rest of the script...
| |
| 15:57 | x=$(function_call)...
| |
| 15:57 | Why the quotes there? DIST=${DIST:-"$(sed -n 's/base_codename=//p' "/usr/share/mintsources/$MINT_DIST/mintsources.conf")"}
| |
| 15:58 | <bennabiy> It was a test to see why the call was failing
| |
| 15:58 | It seems that it is for two reasons, that variable, and also we did not escape our ( )
| |
| 15:58 | <alkisg> if [ -n "$MINT_DIST" ] || ( [ "$(lsb_release -s -i)" = "LinuxMint" ] && [ -z "$DIST" ] ); then
| |
| 15:58 | ==>
| |
| 15:58 | freedomrun has left IRC (freedomrun!~freedomru@unaffiliated/freedomrun, Quit: So long and thanks for all the fish) | |
| 15:58 | <alkisg> better reverse the last 2 ones now
| |
| 15:59 | if [ -n "$MINT_DIST" ] || ( && [ "$DIST" ] && [ "$(lsb_release -s -i)" = "LinuxMint" ] ); then
| |
| 15:59 | <bennabiy> ?
| |
| 15:59 | <alkisg> Calling an executable is a bit "expensive", so do it at the end of the "if" parameters
| |
| 15:59 | So that if DIST is set, it's not called at all, and you save a few msecs :D
| |
| 16:00 | (typo with those && above, but you get the idea)
| |
| 16:00 | <bennabiy> ok, let me make that change, and then I will let you know when to recheck the diff
| |
| 16:01 | <alkisg> bennabiy: did you check that with the parentheses in r2504?
| |
| 16:01 | Maybe { } should be used instead?
| |
| 16:01 | <bennabiy> No, { } does not work, but escaped ( ) works
| |
| 16:02 | perhaps escaped { } would work
| |
| 16:04 | <alkisg> Weird, the unescaped one works for me, and the escaped one is a syntax error
| |
| 16:05 | MINT_DIST=olivia
| |
| 16:05 | LSB_VENDOR=LinuxMint
| |
| 16:05 | if [ -n "$MINT_DIST" ] || ( [ "$LSB_VENDOR" = "LinuxMint" ] && [ -z "$DIST" ] ); then
| |
| 16:05 | echo yes
| |
| 16:05 | fi
| |
| 16:05 | produces: yes
| |
| 16:05 | Both in bash and dash
| |
| 16:05 | ...and posh
| |
| 16:05 | While the escaped version,
| |
| 16:06 | if [ -n "$MINT_DIST" ] || \( [ "$LSB_VENDOR" = "LinuxMint" ] && [ -z "$DIST" ] \); then echo yes; fi
| |
| 16:06 | produces:
| |
| 16:06 | bash: [: missing `]'
| |
| 16:06 | bennabiy: ^
| |
| 16:06 | <bennabiy> Funny thing, you cant test it just within a single script
| |
| 16:07 | I just did testing on a live machine by changing the code around until it would produce the desired result
| |
| 16:08 | check my diff now
| |
| 16:09 | It looks like it is because you did not space between ] and \)
| |
| 16:10 | might just be my eyes
| |
| 16:11 | I guess it was just my eyes
| |
| 16:11 | * bennabiy shrugs | |
| 16:11 | <bennabiy> on my machine, actually running the code on a machine, it works
| |
| 16:12 | <alkisg> Did you set MINT_DIST when you ran it?
| |
| 16:12 | <bennabiy> Nope
| |
| 16:13 | I gotta go for about 30 minutes...
| |
| 16:13 | I commited and pushed.
| |
| 16:13 | And tested
| |
| 16:13 | <alkisg> ok :)
| |
| 16:13 | <bennabiy> what didnt work was building an ubuntu chroot without it trying to pull the mint stuff
| |
| 16:13 | <alkisg> bennabiy: you can also try: sh -n file
| |
| 16:13 | To syntax test a file
| |
| 16:14 | <bennabiy> so I had to escape the ( )
| |
| 16:14 | <alkisg> If it doesn't pass the syntax test... it can't be committed upstream :)
| |
| 16:15 | ...although that one passes :D
| |
| 16:16 | With MINT_DIST set though, it does produce a syntax error
| |
| 16:22 | [ true ] right_parenthesis_or_whatever_else
| |
| 16:22 | bash: [: missing `]'
| |
| 16:36 | brunolambert has left IRC (brunolambert!brunolambe@nat/revolutionlinux/x-thpliemsabtodqtp, Quit: Leaving.) | |
| 16:38 | vagrantc has joined IRC (vagrantc!~vagrant@freegeek/vagrantc) | |
| 16:38 | brunolambert has joined IRC (brunolambert!brunolambe@nat/revolutionlinux/x-rufhlkqqahxogmmn) | |
| 16:42 | <bennabiy> Hmm
| |
| 16:46 | alkisg: What was happening before I escaped the ( ) was if I built a normal "mint" build, it was working fine (after I fixed the variable issue) but when I tried to manually set DIST to raring, it was still pulling the mint packages
| |
| 16:46 | <alkisg> bennabiy: escaped \( is no longer part of the shell syntax, it's a command, like ls or a function call... for example:
| |
| 16:46 | sudo ln -s ls /bin/\(
| |
| 16:46 | \(
| |
| 16:46 | autogen.sh client common COPYING ltsp.spec obsolete po release.conf server TODO
| |
| 16:48 | <vagrantc> could also set LSB_RELEASE from basic-configuration ...
| |
| 16:49 | if it's not being set via detect_vendor
| |
| 16:49 | <alkisg> detect_vendor is called in a subshell, $(), so setting vars won't make them stick
| |
| 16:49 | <bennabiy> no need, if the call is just happening that one time
| |
| 16:49 | ( <TEST> ) Group a test (for precedence). Attention: In normal shell-usage, the "(" and ")" must be escaped; use "\(" and "\)"!
| |
| 16:50 | <alkisg> Where is that from?
| |
| 16:50 | <bennabiy> according to wiki.bash-hackers.org
| |
| 16:50 | http://wiki.bash-hackers.org/commands/classictest
| |
| 16:50 | <alkisg> They're referring to people that don't want to use ( as syntax
| |
| 16:50 | But e.g. as a part of a filename, an mp3...
| |
| 16:51 | cp My\(.mp3 /path
| |
| 16:52 | Escaped or quoted, it's the same thing, cp "My(.mp3" /path
| |
| 16:53 | <bennabiy> Look under Precedence and Parenthesis
| |
| 16:53 | It explains a little more why
| |
| 16:53 | For the test command, the precedence parenthesis are, as well, ( ), but you need to escape or quote them, so that the shell doesn't try to interpret them:
| |
| 16:53 | <alkisg> You still got that wrong, but it needs a bit more of explaining
| |
| 16:54 | * vagrantc wonders what all the \( vs. "(" is about? | |
| 16:54 | <alkisg> [ is a "normal command", not so much part of the shell syntax
| |
| 16:54 | <vagrantc> and $() is different than ()
| |
| 16:54 | <bennabiy> vagrantc: I think we are talking about two different things
| |
| 16:54 | <alkisg> So you pass parameters to [ in the same sense that you pass parameters to `test` or `ls`
| |
| 16:54 | <bennabiy> true
| |
| 16:54 | <alkisg> If you wanted to list a file whose name was a left parenthesis, you'd do: ls \(
| |
| 16:54 | Or, ls "("
| |
| 16:55 | It's the same for [, to pass it a first parameter of "(", you either need to escape it, or quote it
| |
| 16:55 | [ "(" or [ \(
| |
| 16:55 | Otherwise shell would interpret ( as part of the syntax, and wouldn't pass it as a parameter to [
| |
| 16:56 | So what we're talking now is not at all related to what you committed...
| |
| 16:56 | vagrantc: http://bazaar.launchpad.net/~bennabiy/ltsp/ltsp-LinuxMint/revision/2504
| |
| 16:57 | bennabiy is saying that it won't work without the escaping, I'm saying it's a syntax error
| |
| 16:58 | <ogra_> smells like a bashism
| |
| 16:58 | <bennabiy> I tried it both ways, and one built the right system, the other didnt
| |
| 16:58 | <alkisg> ogra_: nah, it actually produces an error message in bash
| |
| 16:59 | <ogra_> using prenthesis ther i mean
| |
| 16:59 | <alkisg> \( [ "$LSB_VENDOR" = "LinuxMint" ] && [ -z "$DIST" ] \)
| |
| 16:59 | that means "run an executable called left-parenthesis"
| |
| 16:59 | <ogra_> (no matter if escaped or not)
| |
| 16:59 | <alkisg> ...with the rest as parameters
| |
| 17:01 | <bennabiy> alkisg: can you explain why it works on my system now, and did not work without escaping it?
| |
| 17:01 | <vagrantc> that's definitely not valid shell...
| |
| 17:03 | freedomrun has joined IRC (freedomrun!~freedomru@unaffiliated/freedomrun) | |
| 17:04 | <alkisg> bennabiy: no, I don't see why it would work, unless e.g. you have MINT_DIST set somewhere, in a configuration file etc etc
| |
| 17:04 | In any case it's not a valid syntax, so ok let's focus on why it did not work without escaping it for you
| |
| 17:05 | What's your use case?
| |
| 17:05 | <vagrantc> writing up some simple test code it works properly...
| |
| 17:05 | the original
| |
| 17:05 | <alkisg> Mint server, and run ltsp-build-client without parameters?
| |
| 17:05 | <bennabiy> I am calling ltsp-build-client as root using:
| |
| 17:06 | DEBUG=ltsp-build-client ltsp-build-client --arch=i386 --dist=raring
| |
| 17:06 | without the \( it would build a mint chroot
| |
| 17:06 | <vagrantc> DEBUG=true ?
| |
| 17:06 | <alkisg> Ah, here's an idea... if `eval` is called at any place, possibly due to the DEBUG line, it could cause what you've been experiencing
| |
| 17:06 | <bennabiy> with the \( it would build a raring chroot
| |
| 17:07 | ahh! yes
| |
| 17:07 | let me try it without debug in place
| |
| 17:07 | It will be a few minutes until I will see the results
| |
| 17:07 | <alkisg> (I don't think we're using use eval for debug though, it was just an idea...)
| |
| 17:08 | brunolambert has left IRC (brunolambert!brunolambe@nat/revolutionlinux/x-rufhlkqqahxogmmn, Quit: Leaving.) | |
| 17:08 | <alkisg> So... you're trying to build an ubuntu chroot in a mint server
| |
| 17:08 | bennabiy: ...when you say "it didn't work", what did it do, and what did you expect it to do?
| |
| 17:09 | bennabiy_again has joined IRC (bennabiy_again!~Thunderbi@24-181-55-79.dhcp.gnvl.sc.charter.com) | |
| 17:09 | <bennabiy_again> ok, I am on my test machine
| |
| 17:10 | <alkisg> (08:08:20 μμ) alkisg: So... you're trying to build an ubuntu chroot in a mint server
| |
| 17:10 | (08:08:58 μμ) alkisg: bennabiy_again: ...when you say "it didn't work", what did it do, and what did you expect it to do?
| |
| 17:11 | <bennabiy> it built a mint chroot
| |
| 17:11 | brunolambert has joined IRC (brunolambert!brunolambe@nat/revolutionlinux/x-vssyrwmppkfszwsv) | |
| 17:11 | <bennabiy> when it should have built an ubuntu chroot
| |
| 17:12 | <alkisg> bennabiy: you can also put some debug code there to quickly verify if it's working or not,
| |
| 17:12 | e.g. "echo Building a mint chroot" inside the if...
| |
| 17:13 | Because you might be having e.g. mint-core-meta in your ltsp-build-client.conf, and always building a mint chroot, without going inside the if...
| |
| 17:13 | (although that wouldn't explain why it worked for you with the escaping)
| |
| 17:14 | RoeckeWilli has joined IRC (RoeckeWilli!482b12ca@gateway/web/freenode/ip.72.43.18.202) | |
| 17:16 | <bennabiy_again> I do not have a ltsp-build-client.conf for mint :) I am just testing it "out of the box"
| |
| 17:16 | I can try the echo, once this build completes
| |
| 17:17 | ok, it failed, trying to pull in the mint files
| |
| 17:17 | command was ltsp-build-client --arch=i386 --dist=raring
| |
| 17:17 | no debug info
| |
| 17:21 | workingcats has left IRC (workingcats!~workingca@212.122.48.77, Quit: Leaving) | |
| 17:21 | <bennabiy_again> thoughts?
| |
| 17:22 | <alkisg> Put the debug echo :)
| |
| 17:22 | We might be looking at the wrong place for the reason it's failing...
| |
| 17:22 | Also put the var values in the echo
| |
| 17:23 | <bennabiy_again> what is the best way to do that?
| |
| 17:23 | <alkisg> echo "MINT_DIST=$MINT_DIST, LSB_VENDOR=$LSB_VENDOR, builing a mint chroot" >&2 inside the if
| |
| 17:23 | (or something like that...)
| |
| 17:23 | Or `set > /tmp/set`
| |
| 17:24 | <bennabiy_again> remember, I no longer have lsb_vendor
| |
| 17:24 | unless I want to reset that variable again.
| |
| 17:25 | <alkisg> No no, I was just copying from the example we used above
| |
| 17:25 | No need to re-use LSB_VENDOR
| |
| 17:25 | <bennabiy_again> at the point of the script, DIST is really the hinging var
| |
| 17:26 | <alkisg> `set > /tmp/set` will dump all the vars, including DIST
| |
| 17:26 | <bennabiy_again> since I am not using a script to manually set MINT_DIST, nor am I setting it or expecting it to be set from the commandline
| |
| 17:27 | where in the 000-basic-configuration should I dump? right before our test?
| |
| 17:32 | <alkisg> Put it right after the "if" line
| |
| 17:32 | <bennabiy_again> http://pastebin.mozilla.org/3157111 when before the if
| |
| 17:35 | <alkisg> bennabiy_again: DIST isn't set
| |
| 17:35 | Plugins might be setting that after the if...
| |
| 17:35 | <bennabiy_again> it is still option_dist_ ...
| |
| 17:35 | whatever the thing is...
| |
| 17:36 | <alkisg> But the "if" checks for DIST, not option_dist_value
| |
| 17:36 | [ -z "$DIST" ] ==> true, so let's build a mint chroot since we're on a mint server
| |
| 17:37 | <bennabiy_again> exactly
| |
| 17:37 | but when I escape it the ( ) somehow it negates that effect
| |
| 17:37 | <alkisg> No, it just "randomly works"
| |
| 17:37 | <bennabiy_again> hah
| |
| 17:37 | <alkisg> For some other reason that we don't want to debug :)
| |
| 17:37 | * bennabiy_again hides it in a dark corner | |
| 17:38 | <alkisg> Since DIST is set in 001-set-dist, you can't use it in 000-basic-configuration
| |
| 17:38 | <bennabiy_again> hmm
| |
| 17:39 | I wonder who told me to use it?
| |
| 17:39 | I am trying to remember...
| |
| 17:39 | <alkisg> An idea is an idea... when implementing it, you need to look at the details on "where to put that code" etc :)
| |
| 17:39 | <bennabiy_again> heh
| |
| 17:40 | should we just check against option_dist_value?
| |
| 17:40 | [GuS] has joined IRC ([GuS]!~MysT@unaffiliated/gus/x-663402) | |
| 17:40 | <bennabiy_again> since that would be where the initial check that matters happens? then DIST gets set within the if as well
| |
| 17:41 | so I do not think it would shoot us in the foot
| |
| 17:42 | if [ -n "$MINT_DIST" ] || ( [ "$(lsb_release -s -i)" = "LinuxMint" ] && [ -z "$option_dist_value" ] ); then
| |
| 17:43 | <alkisg> First, let me state that since ltsp-pnp, I've stopped using ltsp-build-client, so I'm only willing to discuss some ideas about it, not debug/rewrite the whole thing, :)
| |
| 17:43 | ...but, that said, you just need to move your code a bit later
| |
| 17:43 | E.g. in 001-set-mint-vars
| |
| 17:44 | Also, the current code suffers from the same problem,
| |
| 17:44 | <vagrantc> then you get into the trickiness of setting and resetting DIST
| |
| 17:44 | <alkisg> for example:
| |
| 17:44 | COMPONENTS=${COMPONENTS:-"main restricted universe multiverse"}
| |
| 17:44 | ...COMPONENTS isn't set yet though
| |
| 17:44 | It's set later on, in 001-set-components
| |
| 17:44 | <vagrantc> huh
| |
| 17:44 | <alkisg> So that part of the code doesn't work for the command line, only when using a .conf file
| |
| 17:45 | <bennabiy_again> yes
| |
| 17:45 | <vagrantc> that's actually how it's supposed to work
| |
| 17:45 | i.e. if you set it from the commandline, it will override the defaults, if you set it from a config file, it will override the defaults
| |
| 17:46 | <bennabiy_again> but commandline comes before configure
| |
| 17:46 | <vagrantc> the commandline phase merely sets up the commandline arguments, it doesn't actually set values
| |
| 17:47 | but it does mean that relying on the commandline to set the DIST will not work in basic-configuration
| |
| 17:47 | <bennabiy_again> according to the 001-set-dist it should set DIST=option_dist_value before it ever gets to configure stage
| |
| 17:48 | <vagrantc> no, it sets it during the configure stage
| |
| 17:48 | <bennabiy_again> ahh, you are right, I missed the next case statement
| |
| 17:48 | * vagrantc has at least half the blame for the ltsp-build-client plugin system | |
| 17:48 | <bennabiy_again> only half?
| |
| 17:49 | <vagrantc> yeah, otavio and I hacked on it in 2006
| |
| 17:49 | and otavio doesn't come around here anymore :(
| |
| 17:49 | <bennabiy_again> aww
| |
| 17:49 | <vagrantc> before that, everything was essentially hard-coded for ubuntu.
| |
| 17:49 | <alkisg> Ouch :)
| |
| 17:50 | <bennabiy_again> hmm
| |
| 17:51 | <ogra_> yeah, that initial implementation was all hardcoded :)
| |
| 17:52 | <vagrantc> so i had all the joy of maintaining an entire fork, even for something so close as debian... which lead to "fixing" it.
| |
| 17:52 | it's otavio's fault that all the plugins are prefixed with 0
| |
| 17:53 | * vagrantc suggested NN, and otavio wanted NNN | |
| 17:53 | <bennabiy_again> we appreciate it :)
| |
| 17:53 | why not change them all?
| |
| 17:53 | ;)
| |
| 17:53 | <vagrantc> intertia
| |
| 17:53 | inertia
| |
| 17:53 | <bennabiy_again> heh.
| |
| 17:53 | <vagrantc> internetia
| |
| 17:57 | <bennabiy_again> I wonder how I can get this set, without upsetting the rest
| |
| 17:57 | * bennabiy_again votes for separate LinuxMint folder again | |
| 17:58 | <bennabiy_again> although it still would not fix it
| |
| 17:59 | <vagrantc> would make for more hackery in detect_vendor
| |
| 17:59 | although we're already mangling it
| |
| 17:59 | <bennabiy_again> Actually, if LinuxMint had its own folder, the hackery would be in the LinuxMint folder for both LMDE and Mint proper
| |
| 18:00 | detect_vendor could be returned to its old way
| |
| 18:00 | Would this work?
| |
| 18:00 | <vagrantc> you would have to have every single plugging wrapped in if LMDE else LinuxMintUbuntu
| |
| 18:00 | <alkisg> It would still have the same issue
| |
| 18:01 | <bennabiy> No
| |
| 18:01 | watch :)
| |
| 18:01 | <vagrantc> no, to build plain ubuntu, you could specify VENDOR=Ubuntu
| |
| 18:01 | and it would ignore the Mintisms
| |
| 18:02 | * vagrantc did this to build Debian chroots on Ubuntu servers | |
| 18:02 | <alkisg> You can note down (in vars) whatever you want in 000-basic-configuration, and postpone the "if" for 001-set-mint-overrides
| |
| 18:02 | <vagrantc> and then have commandline options in set-mint-overrides to override the overrides?
| |
| 18:03 | <alkisg> We're basically talking about overriding DIST and EARLY_PACKAGES, right?
| |
| 18:03 | ...their default values, that is...
| |
| 18:04 | <bennabiy> http://pastebin.mozilla.org/3157228
| |
| 18:04 | <alkisg> So, CONF_DIST=$DIST, and CONF_EARLY_PACKAGES=$EARLY_PACKAGES in 000-basic-configuration would be enough "noting down vars"
| |
| 18:04 | ...and then use those in 001-set-mint-overrides to properly decide their values...
| |
| 18:05 | <vagrantc> you could probaably install mint-meta-core in late-packages, noo?
| |
| 18:05 | <bennabiy> It is not a matter of setting them or not, it is a matter of being able to test for them early enough
| |
| 18:05 | <vagrantc> also components
| |
| 18:05 | <alkisg> 001-set-mint-overrides is early enough
| |
| 18:06 | vagrantc: MINT_COMPONENTS is a different value
| |
| 18:06 | *var
| |
| 18:06 | <vagrantc> ah, right :)
| |
| 18:06 | <bennabiy> so would I set the variable in commandline) or configure) ?
| |
| 18:06 | <alkisg> In configure
| |
| 18:06 | <vagrantc> configure
| |
| 18:07 | commandline is only for creating commandline options, not setting values
| |
| 18:07 | <bennabiy> ok
| |
| 18:07 | <alkisg> If you want, you can use "001-set-mint-vars" instead, and provide command line support for mint-dist etc too, all in the same file
| |
| 18:07 | <bennabiy> did you see my suggestion for detect_vendor()?
| |
| 18:08 | <alkisg> In LinuxMint/Ubuntu, you'd have to symlink all the ubuntu scripts
| |
| 18:08 | And in LinuxMint/LMDE, the same
| |
| 18:08 | (for debian)
| |
| 18:09 | So, revised suggestion: (1) note down the configuration values that you need (DIST and EARLY_PACKAGES) in 000-basic-configuration,
| |
| 18:09 | <bennabiy> I guess I would still have to figure out how to get ubuntu chroot to build on mint
| |
| 18:10 | <alkisg> and (2), implement the "if" logic in 001-set-mint-vars, and you can also implement command line options for mint-dist etc there as well
| |
| 18:10 | That should be a small diff to what it is now... and it should work
| |
| 18:11 | At 001-set-mint-vars, DIST would be available for the "if" to work properly
| |
| 18:12 | <bennabiy> so let 000-basic-configuration revert back to basic ubuntu and should I put even MINT_MIRRORS etc in there?
| |
| 18:13 | <alkisg> Something like this: http://pastebin.mozilla.org/3157276
| |
| 18:14 | Then you can use the stored values to properly decide all mint related vars
| |
| 18:14 | Ah
| |
| 18:14 | A better way
| |
| 18:14 | Store them in command line, in 001-set-mint-vars
| |
| 18:14 | That's completely non-intrusive to the other scripts, all mint code is in one file
| |
| 18:15 | So 000-basic-configuration would be reverted to e.g. what it was 1 month ago
| |
| 18:15 | <bennabiy> done.
| |
| 18:15 | <vagrantc> storing values in commandline is kinda ugly...
| |
| 18:16 | at least, conceptually
| |
| 18:16 | <alkisg> Mint needs hacks due to its design :)
| |
| 18:16 | MINT_COMPONENTS?! No other distro needs special component vars...
| |
| 18:16 | MINT_MIRRORS etc etc
| |
| 18:17 | Phantomas has left IRC (Phantomas!~Phantomas@ubuntu/member/phantomas, Remote host closed the connection) | |
| 18:17 | <bennabiy> take it for what it is... I like mint :)
| |
| 18:17 | much better than any modern ubuntu
| |
| 18:17 | <alkisg> I like its code but not its packaging
| |
| 18:17 | <bennabiy> true
| |
| 18:17 | <vagrantc> it's that special not-quite-a-distro role
| |
| 18:17 | <bennabiy> heh
| |
| 18:19 | <vagrantc> debian-edu does some similar things, actually ... although it has it's own mirrors that follow debian's conventions
| |
| 18:20 | <bennabiy> according to the developers, the debian branch is based on debian, but not using the debian repositories. they have their own
| |
| 18:20 | the ubuntu uses both ubuntu repositories and linuxmint repos
| |
| 18:22 | <alkisg> For LMDE, it should be as simple as setting MIRROR and LATE_PACKAGES="mint-core mint-desktop-mate"
| |
| 18:22 | <vagrantc> oh, so the debian variant might actually be easier to implement
| |
| 18:22 | <alkisg> It shouldn't need special-casing...
| |
| 18:23 | <vagrantc> at least, not as much
| |
| 18:25 | <alkisg> (and for Ubuntu the same, setting EARLY_MIRROR which would override the other mirrors, and just marking 2 packages for installation - no need to advertise being a "different distro")
| |
| 18:25 | <ogra_> yeah
| |
| 18:27 | <bennabiy> ok, check my latest
| |
| 18:28 | I think it might work
| |
| 18:30 | <vagrantc> EARLY_MIRROR doesn't change the logic of how apt selects packages, it just controls the order in sources.list
| |
| 18:30 | i.e. newer versions will still get pulled in
| |
| 18:30 | and EARLY_MIRROR was intended as a commandline option to set additional mirrors
| |
| 18:30 | <alkisg> That's what mint does anyway, it just puts a mirror at the top of sources.list,
| |
| 18:30 | <vagrantc> not really to be (ab)used by the plugins themselves
| |
| 18:30 | <bennabiy> where would I need to put the logic if I want to pull in mint's plymouth rather than ubuntus?
| |
| 18:30 | <vagrantc> apt pinning?
| |
| 18:31 | <alkisg> Yes, for kernels
| |
| 18:31 | <vagrantc> does mint use apt pinning by default? that's the only way you could override not installing a new version
| |
| 18:31 | <alkisg> I think it does
| |
| 18:31 | <bennabiy> I think so
| |
| 18:33 | <alkisg> bennabiy: about $lsb_vendor => local variables should be declared with "local lsb_vendor"
| |
| 18:33 | and, about 001-set-mint-dist, you don't save the value of DIST in the commandline, so it won't work properly, let me paste some quick proposal...
| |
| 18:35 | PhoenixSTF has left IRC (PhoenixSTF!~rudi@lidet.uac.pt, Quit: Leaving) | |
| 18:36 | <bennabiy> alkisg: dist should have been set already by 001-set-dist
| |
| 18:36 | at least enough to be test-worthy
| |
| 18:37 | and the MINT_DIST should be set before the test hits for whether it is set
| |
| 18:37 | as my testing IF is after the if to set option_mint-dist_value to MINT_DIST
| |
| 18:38 | <alkisg> bennabiy: I'm talking about this line:
| |
| 18:38 | DIST=${DIST:-"$(sed -n 's/base_codename=//p' "/usr/share/mintsources/$MINT_DIST/mintsources.conf")"}
| |
| 18:38 | In this line, DIST will never be empty
| |
| 18:38 | So the sed there will never be executed
| |
| 18:38 | <bennabiy> ahh, good point
| |
| 18:39 | <alkisg> That's why you need to remember where was DIST set from
| |
| 18:39 | <vagrantc> or use a different variable and then reset dist later...
| |
| 18:39 | <alkisg> If it was set from a configuration file or from the command line, then sed should not be ran, otherwise it should
| |
| 18:39 | * vagrantc missed a paste or something | |
| 18:39 | <bennabiy> I ultimately need to end up with 2 dist variables
| |
| 18:40 | <alkisg> vagrantc: https://code.launchpad.net/~bennabiy/ltsp/ltsp-LinuxMint/+merge/187969
| |
| 18:41 | <bennabiy> but _only_ if DIST is unset or set to a non mint chroot
| |
| 18:42 | <vagrantc> if [ -n "$option_mint-dist_value" ]; then ... needs to be if [ -n "$option_mint_dist_value" ]; then
| |
| 18:42 | and MINT_DIST="$option_dist_value" ... needs to be MINT_DIST="$option_mint_dist_value"
| |
| 18:43 | MINT_DERIVED_DIST for the minsources.conf stuff ?
| |
| 18:43 | reusing DIST seems tricky...
| |
| 18:44 | it obviously needs to be set correctly for the rest of the code to work, but i think making a third DIST-related variable might make the code cleaner...
| |
| 18:44 | insane though that might sound
| |
| 18:45 | <bennabiy> so...
| |
| 18:46 | would mint-dist under the commandline section need to switch to mint_dist ?
| |
| 18:46 | <vagrantc> bennabiy: no
| |
| 18:46 | <bennabiy> gettext wrangles that?
| |
| 18:46 | <vagrantc> bennabiy: yes
| |
| 18:46 | <bennabiy> ok
| |
| 18:47 | <vagrantc> the "-" character is not valid in a variable name
| |
| 18:47 | <alkisg> bennabiy: something like this, completely untested etc etc: http://pastebin.mozilla.org/3157376
| |
| 18:48 | <bennabiy> so if I have mint-dist in the commandline, it will make it option_mint_dist_value later?
| |
| 18:49 | <vagrantc> bennabiy: yes.
| |
| 18:49 | alkisg: could just check against $option_dist_value in configure, no?
| |
| 18:50 | alkisg: that's a pretty good hack, though ...
| |
| 18:51 | <bennabiy> alkisg: That looks pretty good
| |
| 18:52 | <alkisg> (09:49:45 μμ) vagrantc: alkisg: could just check against $option_dist_value in configure, no? ==> do you mean that we could put nothing in commandline) ?
| |
| 18:53 | <vagrantc> alkisg: basically, yes...
| |
| 18:53 | <bennabiy> that sounds reasonable. If someone had manually set dist, then it would already be set by this file
| |
| 18:54 | so we could do all the checking within configure
| |
| 18:54 | <vagrantc> guess it doesn't catch a configuration file setting it
| |
| 18:54 | <alkisg> Nor the command line, DIST=xx ltsp-build-client
| |
| 18:54 | <bennabiy> when does the configuration file get checked?
| |
| 18:54 | <vagrantc> right
| |
| 18:55 | <alkisg> It's sourced before all the 000-xxx scripts
| |
| 18:55 | <bennabiy> so in that case it would not be $option_dist_value, but would be $DIST
| |
| 18:56 | <alkisg> Right, that's why we need to check for both
| |
| 18:56 | <bennabiy> could we not check in configure for both options?
| |
| 18:56 | yes
| |
| 18:56 | <alkisg> No, because it's too late then
| |
| 18:56 | DIST is always set at that point, by 000-basic-configuration
| |
| 18:56 | <vagrantc> gah. mint is crazy.
| |
| 18:56 | <alkisg> Err so the "if" needs to be changed too
| |
| 18:57 | and check for $default_mint_dist instead of $DIST
| |
| 18:57 | <vagrantc> alkisg: and use boolean_is_true instead of -n :P
| |
| 18:57 | <bennabiy> heh
| |
| 18:57 | <alkisg> Hehe, it's an internal variable, not exposed to user configuration files
| |
| 18:57 | <bennabiy> mint is an internal variable
| |
| 18:58 | <vagrantc> alkisg: consistancy! :P
| |
| 18:58 | the -n behaves very wrong when say, for some reason, someone decides to code foo=false
| |
| 18:59 | <willianmazzardo> alkisg, hi … me bothering you again ;)
| |
| 18:59 | <vagrantc> even if they're doing it wrong, it's less clear
| |
| 18:59 | <alkisg> Hi willianmazzardo, what's up?
| |
| 18:59 | vagrantc: we could remember the DIST name instead of true/false then :)
| |
| 19:00 | (and change the var name a bit)
| |
| 19:00 | <vagrantc> alkisg: or just use boolean_is_true :P
| |
| 19:00 | alkisg: why the aversion to it?
| |
| 19:00 | <ogra_> ++
| |
| 19:01 | boolean_is_true is coding art !
| |
| 19:01 | <alkisg> Precious msecs :D
| |
| 19:01 | No, it's not just that...
| |
| 19:01 | <vagrantc> although ! boolean_is_true always throws me for a loop
| |
| 19:01 | <bennabiy> heh
| |
| 19:02 | <ogra_> :)
| |
| 19:02 | <willianmazzardo> alkisg, the printer situation still the same ONLY in WINE app … i have to close the application and reopen to print again … this work for, i dont know, 10 minutes … and again the printer stop :S
| |
| 19:02 | <vagrantc> before you know it my brain is in quadrupal negation and i forgot where my shoes are
| |
| 19:02 | <alkisg> Using boolean_is_true for internal code (not user variables) is like accepting that we have poorly written code, like we don't know what values a var might hold
| |
| 19:02 | Like we can set VAR=1 or VAR=True or VAR=y in different scripts
| |
| 19:02 | <vagrantc> alkisg: i think it's more clearly written code
| |
| 19:03 | <alkisg> Kinda like "we allow tabs AND spaces for identation, do it however you like. You can also use arbitrary tab sizes" :P
| |
| 19:03 | * bennabiy attacks whitespace! | |
| 19:04 | <vagrantc> alkisg: well, we actually should be using 4 spaces as standard practice ... some code isn't consistant, but shouldn't be *fixed* in the middle of other code changes
| |
| 19:04 | course, that's the only time anyone is going to notice...
| |
| 19:05 | <alkisg> Hehe, we'll get to tabs another time
| |
| 19:05 | Tabs should be used, because it's necessary for <<-EOF
| |
| 19:05 | The shell syntax doesn't allow spaces there
| |
| 19:05 | <vagrantc> alkisg: i've just on many occasions encountered the use of -n to test for a boolean, when it was reasonable to set it to false, and gotten very odd behavior.
| |
| 19:06 | <alkisg> willianmazzardo: let's go to a private tab to not interrupt the others chatting here...
| |
| 19:06 | <willianmazzardo> ta
| |
| 19:06 | ok
| |
| 19:06 | <vagrantc> alkisg: and then if it's in our code to sometimes use boolean_is_true, and sometimes use -n, people may not use the right one at the right time
| |
| 19:06 | alkisg: i'd rather just consistantly use boolean_is_true
| |
| 19:07 | those can become precious *hours* of human debugging time
| |
| 19:08 | <ogra_> ++
| |
| 19:08 | <alkisg> Booleans should only have 2 values. It shouldn't be necessary to call a function everytime one needs to check a boolean. While reading booleans from a configuration file, some parsing (boolean_is_true) would be needed, but when in code, they should be converted to "real, 2 value booleans"
| |
| 19:09 | <vagrantc> alkisg: i think we disagree here...
| |
| 19:09 | <alkisg> So boolean_is_true should only be part of a configuration file reading function, it shouldn't even be a public function for all scripts...
| |
| 19:10 | But that's not something that will happen in the ltsp code (at least not in the visible future), so I won't argue more!
| |
| 19:10 | So /me agrees to whatever vagrantc proposes :)
| |
| 19:10 | <ogra_> internally you dont need boolean_is_true, you have the control ...
| |
| 19:10 | <vagrantc> but use it anyways, it's siimpler.
| |
| 19:10 | if it were a one-person coding project, maybe...
| |
| 19:11 | <ogra_> externally people might have the weirdest iseda about what the right value of a boolean is and put it in a config file
| |
| 19:11 | *ideas
| |
| 19:11 | so i would see it completely the other way round
| |
| 19:11 | externally yoou *need* it ... internally its a convenience to have it
| |
| 19:12 | <vagrantc> alkisg: i understand your logic, but i don't think it's worth the pain of a long debugging session.
| |
| 19:12 | <alkisg> I think we completely agree, and that we were just talking about it from different views, me from the theoretical side and you from the practical,
| |
| 19:12 | <ogra_> there were oretty valid reasons back then that boolean_is_true was even written
| |
| 19:12 | <vagrantc> alkisg: right
| |
| 19:12 | <ogra_> *pretty
| |
| 19:13 | <bennabiy> vagrantc and alkisg: jewish argument? You are both right?
| |
| 19:13 | <vagrantc> and besides, you can specify TruE and how cool is that?
| |
| 19:13 | <ogra_> :D
| |
| 19:13 | <vagrantc> or FalSeifyThiSveryBadValue
| |
| 19:14 | anyways, where were we before that tangent?
| |
| 19:14 | * bennabiy lies bleeding on the ground... | |
| 19:15 | <vagrantc> bennabiy: i'm thinking mint-meta-core doesn't need to be in EARLY_PACKAGES ...
| |
| 19:15 | <bennabiy> I think I agree
| |
| 19:15 | <vagrantc> bennabiy: what exactly does it do?
| |
| 19:15 | <bennabiy> it pulls in the mint core stuff, like artwork
| |
| 19:16 | * vagrantc forgets if late-packages happens before or after initrd... | |
| 19:16 | <bennabiy> although I am reconsidering to just pulling in the keychain, the plymouth and seeing if I can get by with that
| |
| 19:16 | <vagrantc> bennabiy: either way, you shouldn't need to mess with early-packages
| |
| 19:19 | <alkisg> Maybe it sets the mirrors and apt pinnning etc too?
| |
| 19:19 | <bennabiy> I think I need to look more to apt-pinning for pulling my mint content in
| |
| 19:21 | monkwitdafunk has left IRC (monkwitdafunk!~AndChat49@24.114.39.8, Ping timeout: 264 seconds) | |
| 19:21 | <bennabiy> Actually, if I could even just get the keychain, the plymouth, and set the mirrors to be ready if someone wants to apt-get something else mintish in their chroot, I would be happy
| |
| 19:22 | I think the difference in file size between Ubuntu raring, and mint equiv with just the mint-meta-core is about 12 MB
| |
| 19:24 | telex has left IRC (telex!~telex@freeshell.de, Remote host closed the connection) | |
| 19:25 | <vagrantc> bennabiy: what are the dependencies of mint-meta-core and what are it's exact contents? i.e. dpkg -L mint-meta-core
| |
| 19:26 | * alkisg wonders if the mint code (menu, panels etc etc) are as hacky as its packaging... | |
| 19:26 | telex has joined IRC (telex!~telex@freeshell.de) | |
| 19:28 | willianmazzardo has left IRC (willianmazzardo!~textual@187.53.208.106, Quit: Computer has gone to sleep.) | |
| 19:29 | <alkisg> Unrelated question... with XSERVER=vesa, some teacher using gnome-fallback has 1024x768 in LDM and 1280x1024 after login (!) without a .config/monitors.xml file... What else could be changing the resolution after login?
| |
| 19:30 | <bennabiy> I am blanking on how to check dependencies
| |
| 19:31 | <alkisg> apt-cache show
| |
| 19:31 | <bennabiy> thank you
| |
| 19:32 | http://pastebin.mozilla.org/3157520
| |
| 19:33 | freedomrun has left IRC (freedomrun!~freedomru@unaffiliated/freedomrun, Ping timeout: 245 seconds) | |
| 19:36 | <bennabiy> Hmm. alkisg: what is the hardware?
| |
| 19:36 | <alkisg> Some SiS graphics card which fails to load without xvesa
| |
| 19:36 | I don't have direct access to it
| |
| 19:37 | <bennabiy> is it xrandr related?
| |
| 19:37 | I was having funny issues because of a false entry of an LVDS display which didnt exist
| |
| 19:38 | have you checked what xrandr shows on the client?
| |
| 19:38 | <alkisg> With vesa? or with sis?
| |
| 19:38 | <bennabiy> either
| |
| 19:38 | <alkisg> With vesa it shows all the resolutions, and it's 1024x768 before login (set with XRANDR_MODE_0), and 1280x1024 afterwards
| |
| 19:39 | But I can't imagine what changes the resolution after login
| |
| 19:39 | <bennabiy> the LDM resolution is hard set ?
| |
| 19:39 | monitors setting?
| |
| 19:39 | You can override the default once you log in
| |
| 19:39 | <alkisg> If XRANDR_MODE_0 isn't set, it defaults to the X default resolution, which would be 1280x1024
| |
| 19:40 | So what I'm wondering about, is, which app changes the resolution... sure, we could write a script that changes it, or use monitors.xml (the gnome screen settings dialog), but it shouldn't be necessary to change resolutions 3 times... :-/
| |
| 19:40 | Phantomas has joined IRC (Phantomas!~Phantomas@ubuntu/member/phantomas) | |
| 19:41 | <bennabiy> Is the monitor trying to mirror another monitor?
| |
| 19:42 | or does it have the ghost LAPTOP display issue?
| |
| 19:42 | 12.04 seemed to be pretty buggy with that
| |
| 19:43 | <alkisg> I think xrandr after login doesn't show a second monitor
| |
| 19:43 | (nor before login)
| |
| 19:43 | I'll check though
| |
| 19:43 | (on Monday...)
| |
| 19:44 | <bennabiy> that is an interesting thing
| |
| 19:45 | well, I will have to puzzle over how to solve my dilemma. Is it possible to at least commit the change in 000-basic-configuration to change LSB_VENDOR to the lsb_release check?
| |
| 19:45 | even if it is not entirely fixed for reverse compatibility, it does fix the need on mint to build mint clients
| |
| 19:46 | is there a bzr command to roll back to a previous commit?
| |
| 19:46 | <vagrantc> bennabiy: you should proably start a new branch on top of ltsp-trunk
| |
| 19:46 | bennabiy: at this point...
| |
| 19:47 | freedomrun has joined IRC (freedomrun!~freedomru@unaffiliated/freedomrun) | |
| 19:47 | <bennabiy> I currently have lp:ltsp on my machine, at current. make a new branch?
| |
| 19:50 | <vagrantc> yeah, rather than continuing to push to your ltsp-LinuxMint repository ...
| |
| 19:50 | since the revision history has diverged...
| |
| 19:51 | generally one branch per feature
| |
| 19:51 | <bennabiy> ok
| |
| 19:52 | can I keep updating my recipe to reflect my latest branch for my testing?
| |
| 19:52 | for my ppa builds?
| |
| 19:52 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Remote host closed the connection) | |
| 19:52 | <vagrantc> bennabiy: i'm not familiar with recipies
| |
| 19:53 | <bennabiy> Ok, new branch is ltsp-LM
| |
| 19:53 | :)
| |
| 19:54 | <vagrantc> what will you do with the next round of mint related changes?
| |
| 19:54 | anyways, gotta go
| |
| 19:54 | * vagrantc waves | |
| 19:54 | <bennabiy> bye!
| |
| 19:54 | I need to go too
| |
| 19:54 | vagrantc has left IRC (vagrantc!~vagrant@freegeek/vagrantc, Quit: leaving) | |
| 19:54 | * bennabiy waves | |
| 19:54 | bennabiy is now known as bennabiy_away | |
| 19:57 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 20:32 | vagrantc has joined IRC (vagrantc!~vagrant@freegeek/vagrantc) | |
| 20:41 | bobby_C has left IRC (bobby_C!~bobby@85-124-22-227.teleworker.xdsl-line.inode.at, Quit: Goin' down hard) | |
| 20:46 | brunolambert has left IRC (brunolambert!brunolambe@nat/revolutionlinux/x-vssyrwmppkfszwsv, Quit: Leaving.) | |
| 20:46 | forrest has joined IRC (forrest!3feb83c2@gateway/web/freenode/ip.63.235.131.194) | |
| 21:01 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Remote host closed the connection) | |
| 21:11 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 21:19 | vagrantc has left IRC (vagrantc!~vagrant@freegeek/vagrantc, Quit: leaving) | |
| 21:26 | vagrantc has joined IRC (vagrantc!~vagrant@freegeek/vagrantc) | |
| 21:44 | freedomrun has left IRC (freedomrun!~freedomru@unaffiliated/freedomrun, Ping timeout: 256 seconds) | |
| 21:44 | alkisg has left IRC (alkisg!~alkisg@ubuntu/member/alkisg, Quit: Leaving.) | |
| 21:49 | staffencasa_ has joined IRC (staffencasa_!~staffenca@8-220.ptpg.oregonstate.edu) | |
| 21:55 | lmds_ has left IRC (lmds_!~lmds@213.41.240.245, Ping timeout: 245 seconds) | |
| 21:56 | lmds_ has joined IRC (lmds_!~lmds@tui.pi-et-ro.net) | |
| 21:57 | staffencasa has left IRC (staffencasa!~staffenca@8-220.ptpg.oregonstate.edu, Read error: Connection reset by peer) | |
| 21:58 | freedomrun has joined IRC (freedomrun!~freedomru@unaffiliated/freedomrun) | |
| 22:04 | gvy has left IRC (gvy!~mike@altlinux/developer/mike, Ping timeout: 246 seconds) | |
| 22:04 | gvy has joined IRC (gvy!~mike@altlinux/developer/mike) | |
| 22:10 | Phantomas has left IRC (Phantomas!~Phantomas@ubuntu/member/phantomas, Quit: Leaving.) | |
| 22:10 | Phantomas has joined IRC (Phantomas!~Phantomas@ubuntu/member/phantomas) | |
| 22:11 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Remote host closed the connection) | |
| 22:25 | biophoton has joined IRC (biophoton!~andy@h35.209.22.98.dynamic.ip.windstream.net) | |
| 22:41 | gbaman has joined IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com) | |
| 22:46 | khildin has left IRC (khildin!~khildin@ip-213-49-85-183.dsl.scarlet.be, Quit: I'm gone, bye bye) | |
| 22:46 | freedomrun has left IRC (freedomrun!~freedomru@unaffiliated/freedomrun, Quit: So long and thanks for all the fish) | |
| 22:50 | gbaman has left IRC (gbaman!~gbaman@host81-130-119-33.in-addr.btopenworld.com, Ping timeout: 248 seconds) | |
| 23:14 | freedomrun has joined IRC (freedomrun!~freedomru@unaffiliated/freedomrun) | |
| 23:15 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.38.201) | |
| 23:18 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.38.201) | |
| 23:20 | xet7 has left IRC (xet7!~xet7@a88-112-147-81.elisa-laajakaista.fi, Quit: Lähdössä) | |
| 23:21 | monkwitdafunk has joined IRC (monkwitdafunk!~AndChat49@24.114.38.201) | |
| 23:47 | biophoton has left IRC (biophoton!~andy@h35.209.22.98.dynamic.ip.windstream.net, Ping timeout: 264 seconds) | |
| 23:52 | freedomrun has left IRC (freedomrun!~freedomru@unaffiliated/freedomrun, Quit: So long and thanks for all the fish) | |
| 23:57 | [GuS] has left IRC ([GuS]!~MysT@unaffiliated/gus/x-663402, Quit: Konversation terminated!) | |